Experienced Devs@programming.devEnglish · 20 hours ago

While reviewing a PR, you find some piece of code that seems to work perfectly well, but some functions are written in a style that you don't particularly favor. What do you do?

23

While reviewing a PR, you find some piece of code that seems to work perfectly well, but some functions are written in a style that you don't particularly favor. What do you do?

Experienced Devs@programming.devEnglish · 20 hours ago

CareerCupid: While reviewing a merge request from a team mate who is working on a new feature, you find some piece of code that seems to work perfectly well, but some functions are written in a style that you don't particularly favor. Your team has a document for code style guidelines, but this case is not covered there. What do you do?

CareerCupid helps you find the best people, jobs and companies to work with

Chat

Boomkop3@reddthat.com
link
fedilink
arrow-up
3·
15 hours ago
If it’s a problem I might do something about it, but I doubt my personal stylistic preferences should determine that of a shared project.

Experienced Devs@programming.dev

experienced_devs@programming.dev

You are not logged in. However you can subscribe from another Fediverse account, for example Lemmy or Mastodon. To do this, paste the following into the search field of your instance: !experienced_devs@programming.dev

A community for discussion amongst professional software developers.

Posts should be relevant to those well into their careers.

For those looking to break into the industry, are hustling for their first job, or have just started their career and are looking for advice, check out:

Logo base by Delapouite under CC BY 3.0 with modifications to add a gradient

Visibility: Public

This community can be federated to other instances and be posted/commented in by their users.

59 users / day
60 users / week
84 users / month
240 users / 6 months
1 local subscriber
4.02K subscribers
74 Posts
661 Comments
Modlog